Comments on: ZFDebug and Doctrine ORM http://danceric.net/2009/06/06/zfdebug-and-doctrine-orm/ Web Developer in Gatineau/Ottawa Fri, 22 Jul 2011 17:17:56 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Alex Gemmell http://danceric.net/2009/06/06/zfdebug-and-doctrine-orm/comment-page-1/#comment-299 Alex Gemmell Fri, 04 Dec 2009 17:01:51 +0000 http://www.danceric.net/?p=477#comment-299 <p>Works for me which is great, thank you! I may tinker with it to be a bit more descriptive :)</p> Works for me which is great, thank you! I may tinker with it to be a bit more descriptive :)

]]> By: Routy Design » Integrating ZFDebug and Doctrine Query Profiling into your Zend Application http://danceric.net/2009/06/06/zfdebug-and-doctrine-orm/comment-page-1/#comment-188 Routy Design » Integrating ZFDebug and Doctrine Query Profiling into your Zend Application Tue, 03 Nov 2009 16:41:56 +0000 http://www.danceric.net/?p=477#comment-188 <p>[...] http://www.danceric.net/2009/06/06/zfdebug-and-doctrine-orm/ and download his latest version of the doctrine ZFDebug [...]</p> [...] http://www.danceric.net/2009/06/06/zfdebug-and-doctrine-orm/ and download his latest version of the doctrine ZFDebug [...]

]]> By: apit http://danceric.net/2009/06/06/zfdebug-and-doctrine-orm/comment-page-1/#comment-32 apit Sat, 01 Aug 2009 17:37:55 +0000 http://www.danceric.net/?p=477#comment-32 <p>hi, thx for your plugin. works great :).</p> hi, thx for your plugin. works great :) .

]]> By: Oleg http://danceric.net/2009/06/06/zfdebug-and-doctrine-orm/comment-page-1/#comment-29 Oleg Fri, 24 Jul 2009 10:03:20 +0000 http://www.danceric.net/?p=477#comment-29 <p>Whoops, some code here also became html. Please fix it! And thanks for this plugin!</p> Whoops, some code here also became html. Please fix it! And thanks for this plugin!

]]> By: Oleg http://danceric.net/2009/06/06/zfdebug-and-doctrine-orm/comment-page-1/#comment-28 Oleg Fri, 24 Jul 2009 10:01:57 +0000 http://www.danceric.net/?p=477#comment-28 <p>Hi, Dan!</p> <p>There is htmlspecialchars() missing for bindings list that cause to output direct html in case it appears in binding.</p> <p>So I created a patch for it:</p> <pre><code>--- /zfdebugdoctrine/library/Danceric/Controller/Plugin/Debug/Plugin/Doctrine.php Пт июл 24 12:51:05 2009 +++ /danceric/zfdebugdoctrine/library/Danceric/Controller/Plugin/Debug/Plugin/Doctrine.php Пт июл 24 12:39:28 2009 @@ -103,8 +103,14 @@ $html .= $info; $params = $event->getParams(); - if(!empty($params)) { - $html .= '<ul><em>bindings:</em> <li>'. implode('</li><li>', $params) . '</li></ul>'; + if(!empty($params)) + { + $html .= '<ul><em>bindings:</em>'; + foreach( $params as $param ) + { + $html .= '<li>' . htmlspecialchars( $param ) . '</li>'; + } + $html .= '</ul>'; } $html .= '</li>'; } </code></pre> Hi, Dan!

There is htmlspecialchars() missing for bindings list that cause to output direct html in case it appears in binding.

So I created a patch for it:

--- /zfdebugdoctrine/library/Danceric/Controller/Plugin/Debug/Plugin/Doctrine.php   Пт июл 24 12:51:05 2009
+++ /danceric/zfdebugdoctrine/library/Danceric/Controller/Plugin/Debug/Plugin/Doctrine.php  Пт июл 24 12:39:28 2009
@@ -103,8 +103,14 @@
                    $html .= $info;

                    $params = $event-&gt;getParams();
-                   if(!empty($params)) {
-                       $html .= '<ul><em>bindings:</em> <li>'. implode('</li><li>', $params) . '</li></ul>';
+                   if(!empty($params))
+                   {
+                       $html .= '<ul><em>bindings:</em>';
+                       foreach( $params as $param )
+                       {
+                           $html .= '<li>' . htmlspecialchars( $param ) . '</li>';
+                       }
+                       $html .= '</ul>';
                    }
                    $html .= '</li>';
                }
]]>